feat(notification-rule): implement new notification pattern #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odex-team/hawk.api.nodejs into update-notification-rule-types
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 54.62% 54.62%
=======================================
Files 9 9
Lines 119 119
Branches 10 10
=======================================
Hits 65 65
Misses 50 50
Partials 4 4 ☔ View full report in Codecov by Sentry. |
e11sy
changed the title
…odex-team/hawk.api.nodejs into update-notification-rule-types
neSpecc
approved these changes
Feb 1, 2025
neSpecc
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of work on new notification model
check related PRs in:
Changes
ReceiveTypes.ALL, we haveReceiveTypes.SEEN_MOREinsteadthresholdandthresholdPeriodproperties to notificationRule entities